Ticket #919 (closed enhancement: fixed)

Opened 2 years ago

Last modified 13 months ago

support external template sets

Reported by: russ Owned by: npeterson
Priority: critical Milestone: 0.9.3_rc3
Component: ambra Version: 0.9-SNAPSHOT
Keywords: configuration Cc:

Description (last modified by russ) (diff)

there should be an easy way to include external template sets in a build/package.

  • get rid of the existing head/journals folders (where do ambra and override journals go then?)
  • stop building journal template jars that are then overridden in the filesystem. we should just used the filesystem.
  • it should be possible to drop template folders into a running system
  • there should be a maven build target that includes external template sets
  • there should be a teamcity build target that includes plos template sets

Change History

Changed 2 years ago by russ

also currently required:

  • an edit to struts.xml to include the struts-template.xml file

Changed 2 years ago by amit

  • keywords configuration added
  • priority changed from high to critical

After looking at the state of the ambra.xml configuration file, I suspect that we need to do a lot more cleanup here. I think ambra.xml needs to be made the commons configuration ConfigurationFactory? configuration file to allow it to add or override settings easily. This will allow us to pull out definitions into multiple files (for example, each journal setup is in another configuration file). Please see  Configuration.

If the quick fix was half a days work, we would do it, but I suspect any quick fix will probably take as much as doing it well. If we get resources freed up we will do it for 0.9, else right after. Increasing priority though.

Changed 2 years ago by amit

Pradeep pointed me to the updated page  Configuration.

Changed 2 years ago by russ

(In [5570]) moving (almost) everything out of journals/ambraJournal and into root

addresses #919 address #855

we'll work towards removing the need for a default journal at all.

Changed 21 months ago by amit

  • owner changed from amit to dragisak
  • blockedby set to 922, 923, 924, 925, 930, 931

We should look at the new CAS build set-up to see if we can follow the same concept here.

Changed 17 months ago by rcave

  • milestone set to 0.9.3_rc2

Moving to 0.9.3_rc2 as part of the template cleanup.

Changed 16 months ago by npeterson

  • milestone changed from 0.9.3_rc2 to 0.9.3_rc3

template cleanup rescheduled for 0.9.3_rc3

Changed 15 months ago by russ

  • description modified (diff)

Changed 15 months ago by russ

  • description modified (diff)

Changed 14 months ago by dragisak

(In [7771]) Remove the need to build journal template jar files. Instead, templates are placed under directory specified in ambra.virtualJournals.templateDir configuration paramater.

  • Each journal is placed under journals/journal-name
  • Journal configuration file is placed in journals/journal-name/configuration/journal.xml
  • Freemarker templates and static resources (images, css, javascript, etc) are placed under journals/journal-name/webapp

Deployment can be done directly from version control system if ambra.virtualJournals.templateDir is set to point to source head directory.

Addresses #919

Changed 14 months ago by dragisak

(In [7772]) Refactor sample journals to work with new template mechanism. Addresses #919

Changed 14 months ago by dragisak

(In [7773]) Refactor sample journals to work with new template mechanism. Addresses #919

Changed 14 months ago by dragisak

(In [7774]) Should have been part of r7772. Refactor sample journals to work with new template mechanism. Addresses #919

Changed 14 months ago by dragisak

  • status changed from new to assigned
  • owner changed from dragisak to rcave

Changed 14 months ago by npeterson

  • status changed from assigned to verify
  • owner changed from rcave to npeterson
  • resolution set to fixed

Changed 14 months ago by dragisak

(In [7786]) Add sample journals to Ambra RPM.

They will be installed in /usr/local/ambrta/templates directory.

References #919

Changed 14 months ago by dragisak

(In [7787]) Remove override for find method. Static resources are now handled by JournalStaticResourceFilter?. See #919

Changed 13 months ago by npeterson

  • status changed from verify to closed
Note: See TracTickets for help on using tickets.