Advanced Search not applying journal filter

[rcave]

Advanced search on PLoS Genetics for author "DeRisi?" gives results for a PLoS ONE and a PLoS Pathogens article. The URLs are built with PLoS Genetics domain name and article DOI.

 http://www.plosgenetics.org/article/info%3Adoi%2F10.1371%2Fjournal.pone.0000094  http://www.plosgenetics.org/article/info%3Adoi%2F10.1371%2Fjournal.ppat.0020025

[rcave]

Note that in future versions of Advanced Search, we will give users the ability to search across journal boundaries.

[russ]

it looks like the filter is not being invoked if the article is cached.

is it possible to add a journal parameter to the search itself, so that the filter is unecessary?

if this is easy, can we do for 0.8.2.2?

[jsuttor]

(In [5263]) addresses #888, add journal to search

• heavy-handed-work-around, not a fix
• fix is to:
  • elevate Journal Filters to cache level services
  • cache actual Journal Filters for performance

#888 is being left open for real resolution in 0.9

[alex]

(In [5348]) Merged revisions 5263 via svnmerge from  http://gandalf.topazproject.org/svn/branches/0.8.2.2

........

r5263 | jsuttor | 2008-04-02 16:15:34 -0700 (Wed, 02 Apr 2008) | 7 lines

addresses #888, add journal to search

• heavy-handed-work-around, not a fix
• fix is to:
  • elevate Journal Filters to cache level services
  • cache actual Journal Filters for performance

#888 is being left open for real resolution in 0.9

........

[amit]

I think we need to add 'Journals' as another filter for 'Advanced Search'. By default, within a journal, this field (in the Advanced Search page) should be set to that Journal. But the user should be able to override it to state 'All Journals'.

Transferring to Rich for further thought.

[rcave]

I agree but journal filters a problematic. Currently, the search result will add the article DOI to the existing base URL. So a ONE paper will appear in genetics e.g.  http://www.plosgenetics.org/article/info%3Adoi%2F10.1371%2Fjournal.pone.0000094

The paper displays correctly (even with the "Published in PLoS ONE" text under the article banner) but figure links return

2008-05-09 10:33:51,834 WARN  SecondaryObjectAction(PLoSGenetics)> Couldn't retrieve secondary object for URI: info :doi/10.1371/journal.pone.0000094 [TP-Processor2626 org.plos.article.action.SecondaryObjectAction]
org.plos.article.util.NoSuchArticleIdException: (id = 'info:doi/10.1371/journal.pone.0000094')

This needs to be corrected before the Journal drop down can be added to the Advanced Search form.

[amit]

Shouldn't this be getting always redirected to the DOI Resolver?

[amit]

Sorry, I meant the URL there should always be that of the DOI Resolver so it then redirects it back to the correct journal.

[rcave]

Sounds like the correct way to handle the URLs.

[amit]

Assigning to Alex...

[amit]

Assigning to Jon.

[amit]

(In [5989]) Replaced the link in the search result page to point to the doi resolver. This is a hack till search is fixed to return results not requiring something else to (doi resolver) to fix the problem. Addresses #888

NOTE: Could someone please eyeball the lines I deleted as I think there was an extra </span> there?

[amit]

While we might have addressed the immediate need for 0.9, we really need to fix this properly. Increasing priority and moving it out of 0.9.

[amit]

Duplicate of #744.