Remove default journal from advanced search templates

[rcave]

For PLoS journal templates, the default journal shouldn't be included in the journals that can be searched. We don't publish any articles to the default journal and is confusing to the user.

[ssterling]

By default, all journals are included in the Cross Journal Search list. To remove a journal from that list, the "isIncludeInCrossJournalSearch" property must be added to the journal.xml config file for that journal. This example uses the PLoSDefault journal:

<config>

<ambra>

<virtualJournals>

<PLoSDefault>

<isIncludeInCrossJournalSearch>false</isIncludeInCrossJournalSearch>

</PLoSDefault>

</virtualJournals>

</ambra>

</config>

The journal.xml config files (for the Ambra journal and Overlay journal) in the SVN repository do not contain this property because, if someone downloads Topaz and Ambra but does not use the plos-templates, then the cross-journal search list will contain no journals.

[rcave]

On demo, the is no Ambra journal specified in ambra.xml but the Ambra journal is appearing in the Advanced Search page (see attached).

    <virtualJournals>
      <templateDir>/var/local/plos-templates/head</templateDir>
      <default>PLoSDefault</default>
      <journals>PLoSDefault,PLoSBiology,PLoSClinicalTrials,PLoSCompBiol,PLoSGenetics,PLoSMedicine,PLoSNTD,PLoSONE,PLoSPathogens</journals>
    </virtualJournals>

In ./journals/AmbraJournal/configuration/journal.xml

<config>
  <ambra>
    <!-- virtual journal config -->
    <virtualJournals>
      <AmbraJournal>
...
        <isIncludeInCrossJournalSearch>false</isIncludeInCrossJournalSearch>
      </AmbraJournal>
    </virtualJournals>

But this shouldn't be called. It seems like there is something borked with the template overlays.

[rcave]

Ambra appearing in advanced search

[ssterling]

I have found that if I add to ambra.xml the config property:

<config>

<ambra>

<virtualJournals>

<AmbraJournal?>

<isIncludeInCrossJournalSearch>false</isIncludeInCrossJournalSearch>

</AmbraJournal>

</virtualJournals>

</ambra>

</config>

it removes "PLoS Default" from the list of journals that can be searched during a cross-journal search.

Perhaps the application believes that it should have an "AmbraJournal?" journal and, since there is no appropriate configuration file (e.g., journal.xml), the properties for the default journal "PLoSDefault" are used instead. The display name for the PLoSDefault journal is "PLoS Default", the same value we are trying to remove from that list of journals on the Search Start page.

Setting this property in ambra.xml probably just covers up the bug, so it should be used only as a last resort.

[dragisak]

(In [7814]) JournalKeyService? should get list of all journals from configuration file, not the database. In testing/dev environment you can have all kind of rubbish in db but relevant journals are only the ones specified in the ambra.virtualJournals.journals. They all should already be created in database by JournalCreator?.

Addresses #1393