Ticket #1337 (closed defect: fixed)

Opened 9 months ago

Last modified 9 months ago

ToC Headings are incorrect

Reported by: npeterson Owned by: npeterson
Priority: critical Milestone: 0.9.3_rc2
Component: ambra Version: 0.9.3
Keywords: Cc:

Description

News from Arabidopsis on the Meiotic Roles of Blap75/Rmi1 and Top3α has been classified as an Interview - it's actually a Perspective. See screenshot.

Is this a one off or do we need to check every piece of front matter has been correctly designated?

 http://plosgenetics-demo.plos.org/article/browseIssue.action?issue=info%3Adoi%2F10.1371%2Fissue.pgen.v04.i12#tocGrp_1

Change History

Changed 9 months ago by npeterson

Correction - there appear to be fundamental problems here. A large number of article types have been wrongly listed (e.g., Editorial instead of Interview, Correspondence instead of Correction).

Here is a sampling of links that list the wrong article types altogether (but almost all ToCs? are affected):

 http://plosgenetics-demo.plos.org/article/browseIssue.action?issue=info%3Adoi%2F10.1371%2Fissue.pgen.v01.i01#tocGrp_1 [] (Interview wrongly listed as Editorial)

 http://plosgenetics-demo.plos.org/article/browseIssue.action?issue=info%3Adoi%2F10.1371%2Fissue.pgen.v01.i05 [] (Correction wrongly listed as Research Articles)

 http://plosgenetics-demo.plos.org/article/browseIssue.action?issue=info%3Adoi%2F10.1371%2Fissue.pgen.v01.i06 [] (Review wrongly listed as Interview)

 http://plosgenetics-demo.plos.org/article/browseIssue.action?issue=info%3Adoi%2F10.1371%2Fissue.pgen.v02.i02 [] (Review wrongly listed as Special Report)

 http://plosgenetics-demo.plos.org/article/browseIssue.action?issue=info%3Adoi%2F10.1371%2Fissue.pgen.v02.i04 [] (Review wrongly listed as Editorial)

Can we have another chance to check this before it goes live because as things stand I've been too distracted by the wrongly listed article types to check anything else?

Changed 9 months ago by npeterson

There is a bug in browseIssue.action when displaying two single articles with different article type headings. The XML for the articles is correct.

Here's another example:  http://plosgenetics-demo.plos.org/article/browseIssue.action?issue=info%3Adoi%2F10.1371%2Fissue.pgen.v04.i09 []

The first article is a Perspective and the second article is a Review. But both are labeled as Perspective.

My hunch is that somebody forgot to close a loop in the code.

Changed 9 months ago by ssterling

(In [7743]) On the Browse Issue page, fixed the ToC article group headers so they match the type of articles in the group that they head.

Addresses #1337

Changed 9 months ago by ssterling

  • status changed from new to verify
  • owner changed from ssterling to npeterson
  • resolution set to fixed

Changed 9 months ago by rcave

The CVS changes are not reflected in ambra_0-9-3-1_branch for the following files:

./template-sets/medicine/struts/journals/medicine/article/browseIssue.ftl
./template-sets/plosone/struts/journals/plosone/article/browseIssue.ftl
./template-sets/biology/struts/journals/biology/article/browseIssue.ftl 

Changed 9 months ago by rcave

  • status changed from verify to reopened
  • owner changed from npeterson to josowski
  • resolution fixed deleted

Changed 9 months ago by josowski

  • status changed from reopened to verify
  • owner changed from josowski to npeterson
  • resolution set to fixed

Changes for this should now be merged, I can't desk check these, so please notify me as soon as it's pushed to demo and/or perftest.

Changed 9 months ago by rcave

  • status changed from verify to closed

Verified fixed

Note: See TracTickets for help on using tickets.