Ticket #1333 (closed defect: fixed)

Opened 15 months ago

Last modified 15 months ago

Change string on article type blurbs to "what is the <article_type> article type?"

Reported by: npeterson Owned by: npeterson
Priority: low Milestone: 0.9.3_rc2
Component: ambra Version: 0.9.3
Keywords: Cc:

Description

-- the article 'a' in the pop-up text (when you hover over the info icon) is awkward and incorrect for certain article types. for example, 'what is a essay' or 'what is a neglected diseases'. can we either detect when it should say 'a' vs 'an' vs no article, or just delete the 'a' entirely and say, for example, 'what is Neglected Diseases?' or 'what is the neglected diseases article type?'

Change History

Changed 15 months ago by josowski

(In [7738]) The article blurb can be awkward and incorrect for certain article types, for example, 'what is a essay' or 'what is a neglected diseases'.

Updating the template wording to something a bit more generic. Ex:

"What is the neglected diseases article type?"

References #1333

Changed 15 months ago by josowski

I've also updated the CVS repository for the Biology and Medicine Journals.

Changed 15 months ago by josowski

  • owner changed from josowski to npeterson
  • status changed from new to verify
  • resolution set to fixed

Changed 15 months ago by rcave

The CVS repository had not been updated. I updated the following files in ambra_0-9-3-1_branch:

./template-sets/medicine/struts/journals/medicine/article/article_blurb.ftl
./template-sets/biology/struts/journals/biology/article/article_blurb.ftl

Changed 15 months ago by josowski

ok, I had committed these changes to the ambra_0-9-3_branch

Changed 15 months ago by rcave

  • status changed from verify to reopened
  • owner changed from npeterson to josowski
  • resolution fixed deleted

Please verify that the logic in the Biology and Medicine templates are correct. It looks like you're checking this in the default template: <#if articleType.code != "research_article">

But you've hardcoded checking for certain article types in the Biology and Medicine templates. There are many other article types that need the generic string (e.g. The PLoS Medicine Debate). And we'll have to update these templates for any new article types. Better to check for !research_article and genericize the string accordingly.

Changed 15 months ago by josowski

There is a requirement for these hard coded strings to display blurbs only for specific articles. Note:  http://joborder.plos.org/view.php?id=10715

We could probably write something much more generic if needed at a later date to determine what blurbs to display for what journals, but I felt this was good enough for now.

Regardless, I've improved the template to just not display the code, instead of displaying an error.

Changed 15 months ago by josowski

  • status changed from reopened to verify
  • owner changed from josowski to npeterson
  • resolution set to fixed

Changed 15 months ago by rcave

  • status changed from verify to closed

Verified fixed

Note: See TracTickets for help on using tickets.