Ticket #1266 (closed clarification: fixed)

Opened 11 months ago

Last modified 11 months ago

Broken template display for invalid static pages instead of 404

Reported by: npeterson Owned by: rcave
Priority: high Milestone: 0.9.3_rc1
Component: ambra Version: 0.9.2
Keywords: Cc:

Description

When viewing a page that doesn't exist, the template display is broken. It should be displaying a Page Doesn't Exists error. For example:

 http://www.plosone.org/static/tchecklist.action []

In the log:

2009-04-17 10:28:38,513 ERROR runtime(PLoSONE)> [TP-Processor155 freemarker.runtime] Error reading included file journals/plosone/static/tchecklist.ftl The problematic instruction:


==> include "${templateFile}" [on line 31, column 1 in templates/main_template.ftl]


Java backtrace for programmers:


freemarker.template.TemplateException?: Error reading included file journals/plosone/static/tchecklist.ftl

Change History

Changed 11 months ago by russ

only happens for static actions

 http://www.plosone.org/tchecklist.action [] gives page not found

probably related to the static action automation that dragisa added in, iirc, 0.9.1

we should return page not found if there's no matching freemarker template for a given action name.

Changed 11 months ago by josowski

(In [7615]) Fixes the pageNotFound issue introduced in r6553. Now if a page fails when being viewed under static content, we assume it's a 404 error. Freemarker offers no way to determine if a template exists or not. We may want to add a method to this in the action class eventually.

References #1266

Changed 11 months ago by josowski

  • owner changed from josowski to rich
  • type changed from defect to clarification

Changed 11 months ago by rcave

  • status changed from new to closed
  • resolution set to fixed

Verified that 404 is displayed for incorrect actions.

Note: See TracTickets for help on using tickets.