Ticket #1122 (closed clarification: worksforme)

Opened 19 months ago

Last modified 16 months ago

don't cache non-existant files

Reported by: russ Owned by: rcave
Priority: high Milestone: 0.9.3_rc1
Component: ambra Version: 0.9.1_rc1
Keywords: Cc:

Description

susanne uploaded a new ntds index page, but neglected to upload one of the images.

 http://www.plosntds.org/images/home/article_v03_i02_junghanss.jpg gave a page not found error.

that error was cached in VirtualJournalMappingFilter?, with the key PLoSNTD-/images/home/article_v03_i02_junghanss.jpg

VJMF is an eternal cache. when the image was uploaded, it continued to return page not found for the image, until the cache key was forcibly removed.

VJMF should be smarter than this.

Change History

Changed 19 months ago by russ

  • owner changed from rich to russ
  • milestone set to 0.9.2

pradeep suggests testing performance with and without VJM cache enabled - it's probably not providing any value, and could be scrapped as the easiest resolution to this issue.

Changed 18 months ago by russ

  • milestone changed from 0.9.2 to 0.9.3

Changed 17 months ago by russ

  • owner changed from russ to wtoconnor

Changed 17 months ago by russ

if VJMF doesn't provide a significant performance benefit, let's get rid of it.

to test, set maxelements to 0 and disable overflow to disk for VJMF, and run some performance tests (probably worth waiting for scott's perf test script to be complete so we can compare apples to apples)

since VJMF caches paths for asset URLs, any performance testing must download attached images, css, etc. when loading pages.

Changed 17 months ago by wtoconnor

(In [7610]) VJMF is an eternal cache. It will cache the error that results from trying to map things that do not exist. This will persist even when the thing is ingested and does exist. Addresses #1122

Changed 16 months ago by wtoconnor

  • owner changed from wtoconnor to rich
  • type changed from defect to clarification

VJMF has been removed.

Changed 16 months ago by npeterson

  • owner changed from rich to russ

Changed 16 months ago by npeterson

  • priority changed from unassigned to high

Changed 16 months ago by npeterson

  • owner changed from russ to rich

Changed 16 months ago by rcave

  • status changed from new to closed
  • resolution set to worksforme

Confirmed that Ambra is performing correctly in production with the VJMF disabled.

Note: See TracTickets for help on using tickets.