Changeset 7558

Timestamp:

03/25/09 16:36:14 (16 months ago)

Author:

wtoconnor

Message:

Make sure articleList is set by Adds and Removes of articles.

Add and Removed worked before the Update fix. However in the process of fixing update we failed to take in to account problems with Add and Remove.

Addresses #1215

Files:

• head/ambra/libs/otm-models/src/main/java/org/topazproject/ambra/models/Issue.java (modified) (2 diffs)

head/ambra/libs/otm-models/src/main/java/org/topazproject/ambra/models/Issue.java

@@ -46 +46 @@
    */
   public void addArticle(URI article) {
-    List<URI> uriList = getArticleList();
-
+    /*
+     * Since we are doing an on-the-fly data migration (unwisely)
+     * we need to update articleList if it has not been done yet.
+     */
+    if (articleList.isEmpty() && !super.getSimpleCollection().isEmpty())
+      articleList =  new ArrayList<URI>(super.getSimpleCollection());
+    
     //Only add if not there
-    if (!uriList.contains(article))
-      uriList.add(article);
+    if (!articleList.contains(article))
+      articleList.add(article);
 
     //Shadow this addition in the simple collection
@@ -62 +67 @@
    */
   public void removeArticle(URI article) {
-    List<URI> uriList = getArticleList();
+    /*
+     * Since we are doing an on-the-fly data migration (unwisely)
+     * we need to update articleList if it has not been done yet.
+     */
+    if (articleList.isEmpty() && !super.getSimpleCollection().isEmpty())
+      articleList =  new ArrayList<URI>(super.getSimpleCollection());
 
-    if (uriList.contains(article))
-      uriList.remove(article);
+    if (articleList.contains(article))
+      articleList.remove(article);
 
     //Shadow this removal in the simple collection